Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sli2py test iaf ps psp poisson generator accuracy #3096

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Sli2py test iaf ps psp poisson generator accuracy #3096

merged 9 commits into from
Feb 7, 2024

Conversation

janskaar
Copy link
Contributor

@janskaar janskaar commented Feb 6, 2024

I somehow messed up the old branch, this is the test updated from the first code review. Also improved function / variable names in two other tests

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 6, 2024
heplesser
heplesser requested changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer now, just a few small comments left.

testsuite/pytests/sli2py_stimulating/test_iaf_ps_psp_poisson_generator_accuracy.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_stimulating/test_iaf_ps_psp_poisson_generator_accuracy.py Outdated Show resolved Hide resolved
testsuite/pytests/sli2py_stimulating/test_iaf_ps_psp_poisson_generator_accuracy.py Show resolved Hide resolved
@heplesser heplesser merged commit 6a898bf into nest:master Feb 7, 2024
24 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janskaar @heplesser