Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and examples to pass Pylint test R1730 #3117

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix tests and examples to pass Pylint test R1730 #3117

merged 1 commit into from
Feb 27, 2024

Conversation

heplesser
Copy link
Contributor

The R1730 test in Pylint seems to have become active with the recent update from Pylint 3.0.3 to Pylint 3.1.0 in the Github Actions.

This PR makes our tests and examples compatible.

Labeling as critical as it blocks our CI.

@heplesser heplesser added S: Critical Needs to be addressed immediately T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 27, 2024
@heplesser heplesser added this to In progress in PyNEST via automation Feb 27, 2024
terhorstd
terhorstd approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@terhorstd terhorstd added S: High Should be handled next and removed S: Critical Needs to be addressed immediately labels Feb 27, 2024
suku248
suku248 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@suku248 suku248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suku248 suku248 merged commit d303ecf into nest:master Feb 27, 2024
24 checks passed
PyNEST automation moved this from In progress to Done Feb 27, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
@heplesser heplesser deleted the fix-pylint-r1730 branch April 24, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suku248 suku248 suku248 approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heplesser @suku248 @terhorstd