Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in nestkernel/per_thread_bool_indicator.cpp #3120

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix data race in nestkernel/per_thread_bool_indicator.cpp #3120

merged 3 commits into from
Mar 12, 2024

Conversation

jprotze
Copy link
Contributor

@jprotze jprotze commented Feb 28, 2024

No description provided.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Feb 28, 2024
@heplesser heplesser added this to In progress in Kernel via automation Feb 28, 2024
heplesser
heplesser requested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jprotze Thank you for the PR. I just have a few suggestions mainly related to NEST coding conventions.

nestkernel/per_thread_bool_indicator.h Show resolved Hide resolved
nestkernel/per_thread_bool_indicator.h Show resolved Hide resolved
nestkernel/per_thread_bool_indicator.h Outdated Show resolved Hide resolved
nestkernel/per_thread_bool_indicator.h Outdated Show resolved Hide resolved
nestkernel/per_thread_bool_indicator.cpp Outdated Show resolved Hide resolved
nestkernel/per_thread_bool_indicator.cpp Show resolved Hide resolved
Kernel automation moved this from In progress to PRs pending approval Feb 28, 2024
@heplesser
Copy link
Contributor

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

@ackurth
Copy link
Contributor

ackurth commented Mar 1, 2024

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

Will do.

@terhorstd terhorstd added this to the NEST 3.7 milestone Mar 4, 2024
@terhorstd terhorstd mentioned this pull request Mar 4, 2024
Open
jprotze and others added 2 commits March 6, 2024 10:45
@jprotze @heplesser
Apply suggestions from code review
5a01bd5 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@jprotze
Two small fixes
4b185a4
@heplesser heplesser mentioned this pull request Mar 7, 2024
Closed
heplesser
heplesser reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jprotze This looks good to me now. I still wait for results from systematic benchmarks on larger models (first checks look good) and will wait for final approval until then.

@ackurth
Copy link
Contributor

ackurth commented Mar 8, 2024

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

I compared the suggested changes to the current NEST Master, there is no performance regression in our usual benchmarks of the microcircuit model.

@heplesser
Copy link
Contributor

@ackurth Could you benchmark this branch on a single node with microcircuit, up to 128 threads? Just to check that the change does not introduce a performance regression.

I compared the suggested changes to the current NEST Master, there is no performance regression in our usual benchmarks of the microcircuit model.

Excellent, then we can proceed. Thanks!

heplesser
heplesser approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With positive benchmark results, I approve.

suku248
suku248 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@suku248 suku248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jprotze for this PR and @ackurth for benchmarking!

@suku248 suku248 merged commit 6ab67c5 into nest:master Mar 12, 2024
24 checks passed
Kernel automation moved this from PRs pending approval to Done Mar 12, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

@suku248 suku248 suku248 approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Kernel
  
Done
Milestone
NEST 3.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jprotze @heplesser @ackurth @suku248 @terhorstd