Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astrocyte_lr_1994: Store result of expression evaluation in proper variable #3138

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

heplesser
Copy link
Contributor

This PR fixes #3137. I re-ordered lines a bit so that all reference initialization come first, then initialization of genuine variables based on expression evaluation.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 6, 2024
@heplesser heplesser added this to the NEST 3.7 milestone Mar 6, 2024
@heplesser heplesser added this to To do in Models via automation Mar 6, 2024
Copy link
Contributor

@HanjiaJiang HanjiaJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@heplesser heplesser merged commit 0aaa566 into nest:master Mar 12, 2024
24 checks passed
Models automation moved this from To do to Done Mar 12, 2024
@heplesser heplesser deleted the fix-astro-dangling branch April 24, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation
Projects
Models
  
Done
Development

Successfully merging this pull request may close these issues.

Compiler warns about initializing reference with temporary in astrocyte_lr_1994
3 participants