Unify synaptic recordable names for PSC models #502
Conversation
… for amat2_psc, hh_psc*, and iaf_psc_*
| @@ -350,6 +350,16 @@ class amat2_psc_exp : public Archiving_Node | |||
| { | |||
| return S_.V_th_v_; | |||
| } | |||
| double | |||
There was a problem hiding this comment.
Insert and empty line before the function definition. Also, I would suggest to add an inline.
| { | ||
| return S_.I_syn_ex_; | ||
| } | ||
| double |
There was a problem hiding this comment.
Insert and empty line before the function definition. Also, I would suggest to add an inline.
| @@ -310,12 +310,12 @@ class iaf_psc_alpha : public Archiving_Node | |||
| return V_.weighted_spikes_in_; | |||
| } | |||
| double | |||
| get_input_currents_ex_() const | |||
| get_I_syn_ex_() const | |||
There was a problem hiding this comment.
Added empty line and inline.
| @@ -310,12 +310,12 @@ class iaf_psc_alpha : public Archiving_Node | |||
| return V_.weighted_spikes_in_; | |||
| } | |||
| double | |||
| get_input_currents_ex_() const | |||
| get_I_syn_ex_() const | |||
| { | |||
| return S_.y1_ex_; | |||
| } | |||
| double | |||
There was a problem hiding this comment.
Added empty line and inline.
| @@ -313,12 +313,12 @@ class iaf_psc_exp : public Archiving_Node | |||
| return V_.weighted_spikes_in_; | |||
| } | |||
| double | |||
There was a problem hiding this comment.
Added empty line and inline.
| @@ -313,12 +313,12 @@ class iaf_psc_exp : public Archiving_Node | |||
| return V_.weighted_spikes_in_; | |||
| } | |||
| double | |||
| get_input_currents_ex_() const | |||
| get_I_syn_ex_() const | |||
| { | |||
| return S_.i_syn_ex_; | |||
| } | |||
| double | |||
There was a problem hiding this comment.
Added empty line and inline.
|
👍 from me. @jhnnsnk , would you take another quick look? |
|
Reasonable unification. Also OK from my side. @heplesser since this can break somebody's code, should one notify malinglist? |
|
@DimitriPlotnikov Good idea to announce! |
This is a fix for issue #501
The PR sets recordable names for synaptic currents as
"I_syn_ex"or"I_syn_in"for:amat2_psc_exp(added recordables)hh_psc_alphaiaf_psc_alphaiaf_psc_expand removed
"I_ex,"I_in","input_currents_ex","input_currents_in"fromnest_names.