New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 28 mymodule bluegene #55
Conversation
- There was no real difference left between SLIModule and DynModule, therefore DynModule is removed now. - All modules are now created as SLIModule(s). - As a side-effect, the `Uninstall` function for modules has been removed, but it never worked anyways, because DynModule::unregister() only threw an exception; this partially solves trac.617. - On BlueGene, the DynamicLoaderModule is not intialized any longer. This is important, because user-defined models are linked statically on BlueGene and are loaded and initialized via static_modules.h.
… modules for BlueGene, but it has so far only been tested "fake" on OSX.
The file sli/interpreter.cc does not conform to clang-format. Can you call clang-format on this file again. |
The code looks good to me. +1 for merge after TravisCI is satisfied. |
@tammoippen I don't understand the formatting problems. On my machine, I get
and this line about which clang-format complains on Travis
seems perfectly fine to me. I am also surprised that Travis only reports build 89.8 as failing, even though all other builds have the same code. |
Unfortunately, this is due to the version difference: TravisCI uses clang-format 3.6 and on your Mac you use 3.7 (same with me). Also there is no flag in 3.7, which mimics the 3.6 behaviour.
I am also surprised by this: all builds should have failed... |
I'm also happy with the code, so +1 for merging. @tammoippen Can you please click the button if you think that the failing Travis is just a glitch in the format checker? Thanks! |
If this is a glitch, shouldn't this branch get pulled and run against clang-3.6 so that we don't introduce failing files into the stream? |
@apeyser Sounds reasonable. |
It seems TravisCI is using different versions of the I agree with @apeyser, but do not have write permissions to @heplesser's branch. |
Dynamic generation of the nest module and the kernel attributes.
This PR should fix #28 and also partially address trac.526 and trac.617. Specifically
DynModule
is completely removed, as they no longer differed in a meaningful way fromSLIModule
MyModule
) are only built as static libraries and are linked statically into NEST. Other platforms are not affected by this changePotential reviews: @jougs @tammoippen @apeyser