Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #762: PyNEST test result parsing confused by NEST output #788

Merged
merged 3 commits into from Aug 21, 2017
Merged

Fix #762: PyNEST test result parsing confused by NEST output #788

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
365eeb8
Issue762: install the nosetests capturestderr plugin
Jul 18, 2017
ad16987
Issue762: make neosetests output consistent across test cases
Jul 18, 2017
15aeb28
install the nose-acpturestderr plugin from the python package index
Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -80,7 +80,12 @@ before_install:
- sudo apt-get install -y openmpi-bin libopenmpi-dev

# Install nose framework for the Python testsuite.
# (Please note that the nose-capturestderr plugin is needed to suppress NEST output to stderr which may interfere
# with the nosetests output hindering correct log-parsing. stdout it captured by default.)
- sudo apt-get install -y python-nose
- git clone https://github.com/sio2project/nose-capturestderr.git capturestderr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how small this plugin is, do you think it would be possible to include this in the nest repo directly after asking the guy about the license? It would avoid problems if the repo was moved or closed...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would indeed be an option. There is also hope that the stderr-plugin will be part of nosetests itself. Unclear is also whether we stay with nosetests or move to another unit test framework.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtrensch This solution will only work on Travis and makes us dependent on yet another external repository. Users running the testsuite would need to install the plugin manually, complicating things. See also my comment on the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtrensch : Have you tried to use the pypi package for nose-capturestderr 1.2
https://pypi.python.org/pypi/nose-capturestderr/1.2

- cd capturestderr
- sudo python setup.py install

# Install VERA++ and pep8 for static code analysis.
- sudo apt-get install -y vera++ pep8
Expand Down Expand Up @@ -110,6 +115,9 @@ install:
- which python
- python --version
- which pip
- which nosetests
- nosetests --version
- nosetests --plugins
- which cmake
- cmake --version

Expand Down