Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Connector properties and growth factor configurable #850

Merged
merged 9 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@jougs
Copy link
Contributor

jougs commented Oct 31, 2017

This PR replaces #507. For explanations and discussion see the comments there.

@heplesser
Copy link
Contributor

heplesser left a comment

@jougs Thanks for picking this up! I just have two tiny suggestions. Once those are addressed, we can merge, since @mschmidt87 approved the predecessor #507.

@@ -238,6 +238,7 @@ const Name index_map( "index_map" );
const Name individual_spike_trains( "individual_spike_trains" );
const Name inh_conductance( "inh_conductance" );
const Name init_flag( "init_flag" );
const Name init_connector_capacity( "init_connector_capacity" );

This comment has been minimized.

@heplesser

heplesser Nov 6, 2017

Contributor

To keep alphabetical order, this one should come before init_flag.

@@ -134,7 +134,7 @@ void
nest::ConnectionManager::set_status( const DictionaryDatum& d )
{
long init_cap = init_conn_capacity_;
if ( updateValue< long >( d, "init_connector_capacity", init_cap ) )
if ( updateValue< long >( d, names::init_connector_capacity, init_cap ) )

This comment has been minimized.

@heplesser

heplesser Nov 6, 2017

Contributor

I think I would change this name to initial_connector_capacity. Just init_... evokes too strong associations to the verb "initialize" and may therefore be confusing.

@heplesser

This comment has been minimized.

Copy link
Contributor

heplesser commented Nov 7, 2017

Merging now, since @mschmidt87 had approved precursor PR #507 previously and this PR added only minor fixed. Thanks, @jougs and @alexeyshusharin!

@heplesser heplesser merged commit 7829ba3 into nest:master Nov 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.