Make Connector properties and growth factor configurable #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jougs
added
ZC: Kernel
heplesser
requested changes
Nov 6, 2017
There was a problem hiding this comment.
@jougs Thanks for picking this up! I just have two tiny suggestions. Once those are addressed, we can merge, since @mschmidt87 approved the predecessor #507.
nestkernel/nest_names.cpp
Outdated
| @@ -238,6 +238,7 @@ const Name index_map( "index_map" ); | |||
| const Name individual_spike_trains( "individual_spike_trains" ); | |||
| const Name inh_conductance( "inh_conductance" ); | |||
| const Name init_flag( "init_flag" ); | |||
| const Name init_connector_capacity( "init_connector_capacity" ); | |||
There was a problem hiding this comment.
To keep alphabetical order, this one should come before init_flag.
nestkernel/connection_manager.cpp
Outdated
| @@ -134,7 +134,7 @@ void | |||
| nest::ConnectionManager::set_status( const DictionaryDatum& d ) | |||
| { | |||
| long init_cap = init_conn_capacity_; | |||
| if ( updateValue< long >( d, "init_connector_capacity", init_cap ) ) | |||
| if ( updateValue< long >( d, names::init_connector_capacity, init_cap ) ) | |||
There was a problem hiding this comment.
I think I would change this name to initial_connector_capacity. Just init_... evokes too strong associations to the verb "initialize" and may therefore be confusing.
heplesser
approved these changes
Nov 7, 2017
|
Merging now, since @mschmidt87 had approved precursor PR #507 previously and this PR added only minor fixed. Thanks, @jougs and @alexeyshusharin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #507. For explanations and discussion see the comments there.