New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that Run and Cleanup are called after Prepare #898

Merged
merged 3 commits into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@hakonsbm
Contributor

hakonsbm commented Mar 7, 2018

An error will now be raised if Run() or Cleanup() are called without calling Prepare() first.

This fixes #659.

@@ -430,6 +431,7 @@ nest::SimulationManager::prepare()
* kernel().connection_manager.get_min_delay();
kernel().music_manager.enter_runtime( tick );
}
prepared_ = true;

This comment has been minimized.

@apeyser

apeyser Mar 8, 2018

Contributor

We should check at the top of the function that ! prepared_ and otherwise throw an exception like in the other checks.

@apeyser

apeyser Mar 8, 2018

Contributor

We should check at the top of the function that ! prepared_ and otherwise throw an exception like in the other checks.

Show outdated Hide outdated nestkernel/simulation_manager.h
ResetKernel
Cleanup
} fail_or_die

This comment has been minimized.

@apeyser

apeyser Mar 8, 2018

Contributor

And prepare after prepare test.

@apeyser

apeyser Mar 8, 2018

Contributor

And prepare after prepare test.

@apeyser

apeyser approved these changes Mar 8, 2018

👍

@apeyser apeyser merged commit 641f48c into nest:master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hakonsbm hakonsbm deleted the hakonsbm:run_state_checks branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment