Fix issue 830 - Make fails with UnicodeDecodeError #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
heplesser
requested changes
Mar 20, 2018
There was a problem hiding this comment.
@steffengraber This looks very fine already, just two places where I would prefer os.path.join().
extras/help_generator/writers.py
Outdated
| @@ -134,12 +135,14 @@ def write_help_html(doc_dic, helpdir, fname, sli_command_list, keywords): | |||
| else: | |||
| path = os.path.join(helpdir, 'cc') | |||
|
|
|||
| f_file_name = open('{}/{}.html'.format(path, name), 'w') | |||
| f_file_name = io.open('{}/{}.html'.format(path, name), mode='w', | |||
| encoding='utf-8') | |||
There was a problem hiding this comment.
Please build the file name as
os.path.join(path, '{}.html'.format(name))
extras/help_generator/writers.py
Outdated
| "{}/{}.html".format(path, name) | ||
| f_file_name.write(cmdindexstring) | ||
| f_file_name.close() | ||
|
|
||
| f_file_name_hlp = open('{}/{}.hlp'.format(path, name), 'w') | ||
| f_file_name_hlp = io.open('{}/{}.hlp'.format(path, name), mode='w', | ||
| encoding='utf-8') |
There was a problem hiding this comment.
Please build the file name as
os.path.join(path, '{}.html'.format(name))
heplesser
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix issue #830 by using the
io.open()instead of theopen()statement and addingencoding="utf8"to it.