Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added warning against bad use of Rank() #943

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Added warning against bad use of Rank() #943

merged 1 commit into from
Apr 27, 2018

Conversation

heplesser
Copy link
Contributor

See also #937.

@heplesser heplesser added ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Apr 27, 2018
@heplesser heplesser added this to the NEST 2.16 milestone Apr 27, 2018
@heplesser heplesser changed the title Added warning against bad used of Rank() Added warning against bad use of Rank() Apr 27, 2018
jougs
jougs approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I quite liked my original text about the funny results from the SLI documentation of Rank, I think this is a good and important addition.

As this change only concerns documentation I will waive the second review and merge directly.

@heplesser
Copy link
Contributor Author

@jougs Your funny text is still in the SLI documentation for nerds like us, but I thought that a more sober approach would serve the PyNEST-using community at large better :).

@jougs jougs merged commit ad52581 into nest:master Apr 27, 2018
@heplesser heplesser deleted the fix-py-rank-doku branch April 27, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jougs jougs jougs approved these changes

@jessica-mitchell jessica-mitchell Awaiting requested review from jessica-mitchell

@hakonsbm hakonsbm Awaiting requested review from hakonsbm

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
NEST 2.16
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@heplesser @jougs