Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning against bad use of Rank() #943

Merged
merged 1 commit into from Apr 27, 2018
Merged

Conversation

@heplesser
Copy link
Contributor

@heplesser heplesser commented Apr 27, 2018

See also #937.

@heplesser heplesser added this to the NEST 2.16 milestone Apr 27, 2018
@heplesser heplesser requested review from jessica-mitchell and hakonsbm Apr 27, 2018
@heplesser heplesser changed the title Added warning against bad used of Rank() Added warning against bad use of Rank() Apr 27, 2018
@jougs
jougs approved these changes Apr 27, 2018
Copy link
Contributor

@jougs jougs left a comment

Although I quite liked my original text about the funny results from the SLI documentation of Rank, I think this is a good and important addition.

As this change only concerns documentation I will waive the second review and merge directly.

@heplesser
Copy link
Contributor Author

@heplesser heplesser commented Apr 27, 2018

@jougs Your funny text is still in the SLI documentation for nerds like us, but I thought that a more sober approach would serve the PyNEST-using community at large better :).

@jougs jougs merged commit ad52581 into nest:master Apr 27, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@heplesser heplesser deleted the heplesser:fix-py-rank-doku branch Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.