Fixed a bug in the SecondaryEvent delivery #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
requested changes
Jun 4, 2018
nestkernel/event.h
Outdated
| for ( typename std::vector< DataType >::iterator i = coeffarray_as_d_begin_; | ||
| i != coeffarray_as_d_end_; | ||
| i++ ) | ||
| { | ||
| write_to_comm_buffer( *i, pos ); | ||
| elem = *i; | ||
| write_to_comm_buffer( elem, pos ); |
There was a problem hiding this comment.
I would make this even more compact as
const DataType elem = *i;And one should probably be able to do it as a one-liner:
write_to_comm_buffer( static_cast< DataType >(*i), pos );I would prefer that, keeping things as tight as possible.
I would also strongly suggest adding a comment here why this extra effort is necessary.
|
@heplesser You are right, a |
heplesser
approved these changes
Jun 5, 2018
terhorstd
added
T: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #955. The origin of the error is explained in the corresponding issue.
All SecondaryEvents which exist at the moment use
doubleas data type. In this cases the sizes in question are the same (this is actually the case for most data types that I checked), which is why this error remained undetected until now (and cannot be tested with the current master).I have created a branch (based on 5g) where I created an additional SecondaryEvent with
booldata (see https://github.com/janhahne/nest-simulator/tree/5g_bool_sec_event). After merging the fix everything works fine there now.