Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #949: NEST help files (hlp, html) should end with newline #965

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Fix #949: NEST help files (hlp, html) should end with newline #965

merged 1 commit into from
Jun 14, 2018

Conversation

steffengraber
Copy link
Contributor

With this fix, all hlp and html help files generated by NEST end in a newline.

This pr fix issue #949

@heplesser heplesser self-requested a review June 6, 2018 09:24
@heplesser heplesser added ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jun 6, 2018
heplesser
heplesser approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditional on test passing.

@heplesser heplesser merged commit c262efb into nest:master Jun 14, 2018
@steffengraber steffengraber deleted the fix-issue-949 branch March 5, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. ZC: Documentation DO NOT USE THIS LABEL ZP: PR Created DO NOT USE THIS LABEL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steffengraber @heplesser