-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return the Lat/Lng coords of the photosphere as you move though the map #36
Conversation
@@ -83,9 +85,12 @@ public void onStreetViewPanoramaCameraChange(StreetViewPanoramaCamera streetView | |||
panorama.setOnStreetViewPanoramaChangeListener(new StreetViewPanorama.OnStreetViewPanoramaChangeListener() { | |||
@Override | |||
public void onStreetViewPanoramaChange(StreetViewPanoramaLocation streetViewPanoramaLocation) { | |||
if (streetViewPanoramaLocation != null && streetViewPanoramaLocation.links != null ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasnt sure why its looking for links but it was preventing the link from firing when otherwise a change was made. I can add an extra if statement if there is something special we want to handle for this case.
@@ -51,8 +51,8 @@ public void setPov(NSTStreetView view, ReadableMap pov) { | |||
public @Nullable | |||
Map getExportedCustomDirectEventTypeConstants() { | |||
return MapBuilder.of( | |||
NSTStreetViewEvent.eventNameForType(NSTStreetViewEvent.ON_ERROR), MapBuilder.of("registrationName", "onStreetViewError"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed to me the reason the onSuccess Callback wasnt working is because the event names were mismatched. So with this change I made it all the same as whats in the NSTStreetViewEvent.
This PR makes the onSuccess callback possible on android, and it returns the lat and lng in the callback for the photosphere every time you move.