Merge pull request #174 from JasonHK/fix/ConfigService

fix: fixes the infer bug of `ConfigService.get`
nestjs · May 7, 2020 · a265145 · a265145
2 parents 68e0375 + 9df67bc
commit a265145
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/lib/config.service.ts b/lib/config.service.ts
@@ -5,6 +5,7 @@ import {
   CONFIGURATION_TOKEN,
   VALIDATED_ENV_PROPNAME,
 } from './config.constants';
+import { NoInferType } from './types';
 
 @Injectable()
 export class ConfigService {
@@ -29,7 +30,7 @@ export class ConfigService {
    * @param propertyPath
    * @param defaultValue
    */
-  get<T = any>(propertyPath: string, defaultValue: T): T;
+  get<T = any>(propertyPath: string, defaultValue: NoInferType<T>): T;
   /**
    * Get a configuration value (either custom configuration or process environment variable)
    * based on property path (you can use dot notation to traverse nested object, e.g. "database.host").

diff --git a/lib/types/index.ts b/lib/types/index.ts
@@ -1 +1,2 @@
 export * from './config.type';
+export * from './no-infer.type';
diff --git a/lib/types/no-infer.type.ts b/lib/types/no-infer.type.ts
@@ -0,0 +1 @@
+export type NoInferType<T> = [T][T extends any ? 0 : never];