Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes the infer bug of ConfigService.get #174

Merged
merged 1 commit into from
May 7, 2020

Conversation

JasonHK
Copy link
Contributor

@JasonHK JasonHK commented Apr 11, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

When calling ConfigService.get(propertyPath, defaultValue), TypeScript will incorrectly infered the type of defaultValue as the return type if the generic was omitted.

const value: string = this.configService.get('database.host', 'localhost');

Will be infered as:

const value: string = this.configService.get<'localhost'>('database.host', 'localhost');

What is the new behavior?

const value: string = this.configService.get('database.host', 'localhost');

Will be infered as:

const value: string = this.configService.get<string>('database.host', 'localhost');

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec
Copy link
Member

Thank you!

@kamilmysliwiec kamilmysliwiec merged commit a265145 into nestjs:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants