feat(docs): Add nest/terminus documentation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunnerLivio
force-pushed
the
feature/nest-terminus
branch
from
b9885cd
to
16cecd4
Compare
BrunnerLivio
changed the title
weeco
reviewed
Nov 18, 2018
src/app/homepage/pages/recipes/terminus/terminus.component.html
Outdated
Show resolved
Hide resolved
src/app/homepage/pages/recipes/terminus/terminus.component.html
Outdated
Show resolved
Hide resolved
src/app/homepage/pages/recipes/terminus/terminus.component.html
Outdated
Show resolved
Hide resolved
| <span class="filename">app.module.ts</span> | ||
| <pre><code class="language-typescript">{{ terminusOptionsServiceDog }}</code></pre> | ||
| <p> | ||
| If everything done correctly, the response of the server when request the <code>/health</code> |
There was a problem hiding this comment.
Reword the sentence. Especially "the response of the server when request the [...]" is confusing to me as first time reader
BrunnerLivio
force-pushed
the
feature/nest-terminus
branch
3 times, most recently
from
daeb73c
to
4c7782b
Compare
|
Thanks a lot @weeco ! I adjusted and merged your suggestions |
BrunnerLivio
changed the title
|
Great job :) I'm gonna review that locally very soon |
BrunnerLivio
force-pushed
the
feature/nest-terminus
branch
from
4c7782b
to
2c8ad43
Compare
|
Can this be merged? @kamilmysliwiec |
|
Merged! Luckily, it was the last time when we had to create a chapter using HTML+props instead of markdown syntax. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: nestjs/terminus#5
What is the new behavior?
Added documentation for nestjs/termius
Does this PR introduce a breaking change?
Other information
Blockers: