fix(graphql): generate fields as optional when they contain arguments #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields with arguments are usually resolved using a separate method with the @ResolveField() annotation. Having such field generated as a required property thus proves quite cumbersome as it forces assigning a value in the result of parent @query() method. This makes fields with arguments always optional.
seblm
approved these changes
Feb 2, 2023
|
This introduces a (minor but still) breaking change |
Thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fields with arguments are usually resolved using a separate method with the
@ResolveField()annotation.Having such field generated as a required property thus proves quite cumbersome as it forces setting a value for this field in the result of parent
@Query()method.What is the new behavior?
Fields with arguments are always generated as optional.
Does this PR introduce a breaking change?
Other information
Using
/dev/nullas argument toexplorelooks unfortunate to me, please advise for a better solution.