Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): Backport metadata storage refactor bug fix #2739

Closed
wants to merge 1 commit into from

Conversation

jhpierce
Copy link

This PR backports a fix from v11.4.0 to v10.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

#2360 (comment)

Issue Number: 2360

What is the new behavior?

Fields resolver works correctly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Please advise if this PR is not set up correctly for backporting. Thank you!

@jhpierce jhpierce changed the title fix(graphql): Backport metadata storage refactor caused a bug in field resolver fix(graphql): Backport metadata storage refactor bug fix Mar 23, 2023
@rezoled
Copy link

rezoled commented Mar 23, 2023

Looks fine to me, @kamilmysliwiec i don’t know what’s your policy on back-porting bug fixes.

@jhpierce
Copy link
Author

@kamilmysliwiec friendly bump, thank you!

@jhpierce
Copy link
Author

@kamilmysliwiec - We're running a pretty big codebase with a lot of moving parts. Moving to graphql 16 isn't really a tenable option for us, and this bug is preventing us from upgrading to >= 10.0.19. Unfortunately, we also can't update to <= 10.0.16, due to this bug. For some other reason, the handful of in-between versions wouldn't work either, and so we're a bit stuck but are pretty excited about leveraging some new features of v11 and staying up to date!

We'd really appreciate some help here. Thank you!

@kamilmysliwiec
Copy link
Member

Fixed in 10.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants