Merge pull request #10285 from twchn/fix-configurable-module-interface

fix(common): make `ExtraModuleDefinitionOptions` partial in `OPTIONS_TYPE`
nestjs · Sep 19, 2022 · cad561b · cad561b
2 parents a80df52 + c36d6ba
commit cad561b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/common/module-utils/interfaces/configurable-module-cls.interface.ts b/packages/common/module-utils/interfaces/configurable-module-cls.interface.ts
@@ -21,7 +21,9 @@ export type ConfigurableModuleCls<
   new (): any;
 } & Record<
   `${MethodKey}`,
-  (options: ModuleOptions & ExtraModuleDefinitionOptions) => DynamicModule
+  (
+    options: ModuleOptions & Partial<ExtraModuleDefinitionOptions>,
+  ) => DynamicModule
 > &
   Record<
     `${MethodKey}Async`,
@@ -30,6 +32,6 @@ export type ConfigurableModuleCls<
         ModuleOptions,
         FactoryClassMethodKey
       > &
-        ExtraModuleDefinitionOptions,
+        Partial<ExtraModuleDefinitionOptions>,
     ) => DynamicModule
   >;
diff --git a/packages/common/module-utils/interfaces/configurable-module-host.interface.ts b/packages/common/module-utils/interfaces/configurable-module-host.interface.ts
@@ -57,7 +57,7 @@ export interface ConfigurableModuleHost<
     ModuleOptions,
     FactoryClassMethodKey
   > &
-    ExtraModuleDefinitionOptions;
+    Partial<ExtraModuleDefinitionOptions>;
   /**
    * Can be used to auto-infer the compound "module options" type (options interface + extra module definition options).
    * Note: this property is not supposed to be used as a value.
@@ -73,5 +73,5 @@ export interface ConfigurableModuleHost<
    * }
    * ```
    */
-  OPTIONS_TYPE: ModuleOptions & ExtraModuleDefinitionOptions;
+  OPTIONS_TYPE: ModuleOptions & Partial<ExtraModuleDefinitionOptions>;
 }