Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): make ExtraModuleDefinitionOptions partial in OPTIONS_TYPE #10285

Merged
merged 1 commit into from Sep 19, 2022
Merged

fix(common): make ExtraModuleDefinitionOptions partial in OPTIONS_TYPE #10285

merged 1 commit into from Sep 19, 2022

Conversation

twchn
Copy link
Contributor

@twchn twchn commented Sep 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

the OPTIONS_TYPE and ASYNC_OPTIONS_TYPE require all fields of ExtraModuleDefinitionOptions, but ExtraModuleDefinitionOptions has default values which are set in the setExtras function.

What is the new behavior?

the ExtraModuleDefinitionOptions in OPTIONS_TYPE and ASYNC_OPTIONS_TYPE is partial.

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

Pull Request Test Coverage Report for Build 958b8a19-608a-4063-8148-72fa1b21c0b9

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.817%

Totals Coverage Status
Change from base Build 33d64ea6-8564-4074-89ae-b787d2d45c2d: 0.0%
Covered Lines: 6100
Relevant Lines: 6502

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants