Allow Client side Grpc stream cancellation

[micmro]

I'm submitting a...

[ ] Regression 
[ ] Bug report
[ x ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When a connected ClientGrpcProxy unsubscribes the Observable returned for an stream gRPC method the upstream connection stays untouched and the server continuous to send updates, even if no-one's listening.

Expected behavior

When the client unsubscribes it calls cancel() on the ClientReadableStream which triggers a cancelled event on the ServerWritableStream - receiving this ServerGrpc stops consuming it's Observable, so upstream Observables can react to this.

cancel() causes the server to return a 1 CANCELLED: Cancelled error, which should not be propagated, as the cancellation was initiated by user-code on the ClientGrpcProxy side.

Minimal reproduction of the problem with instructions

N/A

What is the motivation / use case for changing the behavior?

Having an reactive upstream polling ServerGrpc that only stops polling when the client diconnects

Environment

Nest version: 5.0.1
 
For Tooling issues:
- Node version: 8.9.4
- Platform:  Mac

[micmro]

I've setup a PR with an implementation and tests. Please let me know if you have any questions/feedback.

[kamilmysliwiec]

PR has been merged. This feature will be available soon

[micmro]

Great. Thanks a lot!

[kamilmysliwiec]

Added in v5.1.0

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.