Feature/grpc cancellation #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when client cancels the server stream gets completed too - client introduced disconnection does not throw errors on the client side - release client's event listener on 'end'
|
Will add more tests over the weekend. |
micmro
force-pushed
the
feature/grpc-cancellation
branch
2 times, most recently
from
58f3ca4
to
8058972
Compare
micmro
force-pushed
the
feature/grpc-cancellation
branch
from
8058972
to
0c8e8fb
Compare
|
Testing done. Should I squish the commits into one? |
|
@micmro Thats a nice fix. @kamilmysliwiec Can we get this merged in. |
|
@kamilmysliwiec That is an awesome feature, would be awesome to have that functionality in place. @kamilmysliwiec Could you please merge it? Waiting for a brighter future. |
| @@ -103,7 +105,9 @@ export class ServerGrpc extends Server implements CustomTransportStrategy { | |||
| return async (call, callback) => { | |||
| const handler = methodHandler(call.request, call.metadata); | |||
| const result$ = this.transformToObservable(await handler); | |||
| await result$.forEach(data => call.write(data)); | |||
| await result$.pipe( | |||
| takeUntil(fromEvent(call, 'cancelled')), | |||
There was a problem hiding this comment.
That is the missing feature. Sounds really awesome. Waiting for that feature to be in place. @micmro thanks for that awesome feature.
|
Great job @micmro 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a connected
ClientGrpcProxyunsubscribes the Observable returned for an stream gRPC method the upstream connection stays untouched and the server continuous to send updates, even if no-one's listening.Likewise the Observables
completeis not getting called.Issue Number: #773
What is the new behavior?
When the client cancels the
ServerGrpcstops consuming it's Observable and the client'scompletegets called.Also:
callget cleaned upgetService<T>got tighten, as it can only be akeyof T- get more help from the comilerDoes this PR introduce a breaking change?
Other information