Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver-minor]: TypeScript 3 support #868

Closed
wbhob opened this issue Jul 12, 2018 · 8 comments
Closed

[semver-minor]: TypeScript 3 support #868

wbhob opened this issue Jul 12, 2018 · 8 comments

Comments

@wbhob
Copy link
Contributor

wbhob commented Jul 12, 2018

I'm submitting a...


[ ] Regression 
[ ] Bug report
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

The TypeScript team just announced TS v3, with new features for monorepo setups much like the Nest core. I'm happy to create a pull request that supports TypeScript v3 and new build features and codependency, I just wanted to open an issue first and gauge Kamil and community support.

Environment


Nest version: 5

 
@shekohex
Copy link
Contributor

Just tell me how we can help, a plan ? i'm 100% in 😺

@kamilmysliwiec
Copy link
Member

TS 3.0 is not stable yet. Anyway, we need to update codebase once it hit the final version.

@wbhob
Copy link
Contributor Author

wbhob commented Jul 14, 2018

yeah, i openned this to suggest starting on it now, so when stable drops, it can be merged in. api shouldn’t change between rc and stable.

@edevil
Copy link

edevil commented Aug 26, 2018

Now that TS 3.0 is out, what is the current status of this task?

@xeoneux
Copy link
Contributor

xeoneux commented Aug 28, 2018

Now that TS supports project references, would it be better to use lerna packages instead of separate repositories for nest dependencies?

@anodynos
Copy link

Has anyone tried to build & run the latest NestJS (5.2.x) with TypeScript 3.0.x ?

@myflowpl
Copy link

@anodynos Just updated my NestJS 5.2.2 project to TypeScript 3.0.3 and it's working with no problems, all tests passes without changing a line of code
I'm using only the stuff from the NestJS Docs, don't write any advanced TypeScript code my self.
If so, go ahead and try it :)

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants