Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecations, update to TypeScript 3.0+ #1322

Merged
merged 5 commits into from
Nov 30, 2018

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Nov 28, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #868

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@kamilmysliwiec kamilmysliwiec added this to the 6.0.0 milestone Nov 28, 2018
@kamilmysliwiec kamilmysliwiec changed the base branch from master to refactor/injector November 28, 2018 23:01
@kamilmysliwiec kamilmysliwiec changed the base branch from refactor/injector to 6.0.0-next November 30, 2018 12:51
@kamilmysliwiec kamilmysliwiec merged commit df9c821 into 6.0.0-next Nov 30, 2018
@delete-merged-branch delete-merged-branch bot deleted the refactor/remove-deprecations branch November 30, 2018 13:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1274

  • 19 of 19 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.807%

Totals Coverage Status
Change from base Build 1270: 0.04%
Covered Lines: 2824
Relevant Lines: 2945

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 30, 2018

Pull Request Test Coverage Report for Build 1278

  • 19 of 19 (100.0%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.807%

Totals Coverage Status
Change from base Build 1270: 0.04%
Covered Lines: 2824
Relevant Lines: 2945

💛 - Coveralls

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants