Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Reproduce issue fixed by PR #213 #221

Closed
wants to merge 2 commits into from

Conversation

gregmagolan
Copy link
Contributor

Tracked down the reason I was having the issue with @param() which is fixed by #213. In my build system I'm transpiling down to es5. This PR sets up the 01-cats-app example to reproduce the issue I saw in my project.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.951% when pulling 5ccf6ee on gregmagolan:reproduce-pr-213 into 79d646f on nestjs:master.

@gregmagolan
Copy link
Contributor Author

Run e2e test in 01-cats-app example to reproduce issue.

Change

    "module": "commonjs",
    "moduleResolution": "node",
    "lib": ["es6", "dom"],
    "target": "es5",

to

    "module": "commonjs",
    "target": "es6",

in 01-cats-app and the issue goes away.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.951% when pulling c4fe4c6 on gregmagolan:reproduce-pr-213 into 79d646f on nestjs:master.

@kamilmysliwiec
Copy link
Member

Hi @gregmagolan! Thanks for reproducing the issue 🙂 I left comment here #213

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants