Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(microservices): add serializer and deserializer, improve performance #2653

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

kamilmysliwiec
Copy link
Member

@kamilmysliwiec kamilmysliwiec commented Jul 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • schedule messages on nextTick to reduce network traffic (better performance)
  • add serializer & deserializer feature to every transport strategy (allow to adapt external services with schema expected by NestJS)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Jul 26, 2019

Pull Request Test Coverage Report for Build 3878

  • 126 of 137 (91.97%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.073%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/server/server.ts 16 17 94.12%
packages/microservices/client/client-proxy.ts 5 7 71.43%
packages/microservices/deserializers/incoming-response.deserializer.ts 6 9 66.67%
packages/microservices/deserializers/incoming-request.deserializer.ts 6 11 54.55%
Totals Coverage Status
Change from base Build 3842: -0.2%
Covered Lines: 3724
Relevant Lines: 3917

💛 - Coveralls

@lock
Copy link

lock bot commented Nov 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants