-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added seconds to logger timestamp #2770
Conversation
At the moment only hours and minutes are logged in the default Logger implementation. This pull request add seconds to default logger format. Note that I don't want to override the whole logger service. It's pretty nice, I just want another timestamp format
Pull Request Test Coverage Report for Build 4116
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, looks good :)
Okay cool |
FWIW, in log files it makes more sense to use an ISO timestamp, e.g. const timestamp = new Date().toISOString(); This way you get millisecond resolution and a canonical format:
|
Thanks! |
Glad to be of help |
@BrunnerLivio @kamilmysliwiec How can I add myself on the contributor list? |
Contributors section is automatically created by GitHub |
Thats odd though my PR was merged, I dont see my profile there @kamilmysliwiec |
@rubiin Your commit could not be mapped with your Github account. As you can see in the commit, the commit-image is the "blank"-default Github avatar. As far as I know you need to have the exact same email address configured in git using Unfortunately, since the PR is already merged, we won't be able to revert that. For upcoming PRs check your account is correctly map with your commits, so your contributions will show up in the contributors chart :) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
At the moment only hours and minutes are logged in the default Logger implementation.
This pull request add seconds to default logger format.
Note that I don't want to override the whole logger service. It's pretty nice, I just want another timestamp format
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The logger now shows seconds
Does this PR introduce a breaking change?
Other information