Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Do not call onModuleInit if is null #2790

Merged
merged 1 commit into from
Aug 24, 2019

Conversation

BrunnerLivio
Copy link
Member

@BrunnerLivio BrunnerLivio commented Aug 22, 2019

Fixes #1252

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

See issue

Issue Number: #1252

What is the new behavior?

It does not call onModuleInit, onApplicationBootstrap, onApplicationShutdown or onModuleDestroy if it is of type null.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.236%

Totals Coverage Status
Change from base Build 4098: 0.0%
Covered Lines: 3638
Relevant Lines: 3820

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.6.0 August 24, 2019 09:10
@kamilmysliwiec kamilmysliwiec added this to the 6.6.0 milestone Aug 24, 2019
@kamilmysliwiec kamilmysliwiec merged commit 36db11c into nestjs:6.6.0 Aug 24, 2019
@lock
Copy link

lock bot commented Nov 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants