bugfix: Updated the location of the 'PreservePath' boolean within the…

[Leth01]

… MulterOptions interface

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

The current MulterOptions interface contains the preservePath boolean as part of the limits object however according to the Multer documentation, as well as Express documentation, this option is independent.

Issue Number: N/A

What is the new behavior?

The location of the preserveOptions boolean has been moved outside of the limits object in the MulterOptions interface.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[Leth01]

Forgive my ignorance here - I'm not a largely experienced developer. I noticed that some of the CI checks were failing - I've had a brief look over the failing test cases and i'm a little confused how the change to the TypeScript interface caused 6 failed tests.

Is this something I should be concerned about? I've never made a PR on such a large repository before.

[kamilmysliwiec]

No worries @Leth01. For some reason, our builds started failing (sometimes) in Travis, which is not the case in the local environment. Once I retrigger the build, all tests should succeed.

[Leth01]

No worries @Leth01. For some reason, our builds started failing (sometimes) in Travis, which is not the case in the local environment. Once I retrigger the build, all tests should succeed.

That's a relief. I was worried I had messed up. :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.