Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/grpc multipackage #3097

Closed
wants to merge 8 commits into from

Conversation

AlexDaSoul
Copy link

before:

grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: 'alone.proto'
    }
}

after:

grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: ['name.package', 'other.package'],
        protoPath: [
        'one.proto',
        'two.proto',
        'any.proto'
        ]
    }
}

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Added use packages and protos from external libraries ang default grpc functionality also https://github.com/grpc/grpc/blob/master/src/proto/grpc/health/v1/health.proto

grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: ['name.package', 'grpc'],
        protoPath: [ 'name.proto', 'health.proto'],
        loader: {
            includeDirs: ['project', 'grpc/health/v1']
        }
    }
}

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Discussion #1733 (comment)

Alex Dukhnovskiy added 3 commits October 2, 2019 16:29
before:
grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: 'alone.proto'
    }
}
after:
grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: ['name.package', 'other.package'],
        protoPath: [
        'one.proto',
        'two.proto',
        'any.proto'
        ]
    }
}
…nfig

before:

grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: 'name.package',
        protoPath: 'alone.proto'
    }
}
after:

grpcOptions: <GrpcOptions>{
    transport: Transport.GRPC,
    options: {
        url: 'url',
        package: ['name.package', 'other.package'],
        protoPath: [
        'one.proto',
        'two.proto',
        'any.proto'
        ]
    }
}
# Conflicts:
#	integration/microservices/src/grpc/grpc.controller.ts
#	packages/microservices/client/client-grpc.ts
#	packages/microservices/server/server-grpc.ts
@AlexDaSoul AlexDaSoul closed this Oct 3, 2019
@AlexDaSoul AlexDaSoul reopened this Oct 3, 2019
@coveralls
Copy link

coveralls commented Oct 3, 2019

Pull Request Test Coverage Report for Build 3622

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 95.12%

Totals Coverage Status
Change from base Build 3491: 0.005%
Covered Lines: 4347
Relevant Lines: 4570

💛 - Coveralls

@marcus-sa
Copy link

marcus-sa commented Oct 4, 2019

Could you add support for globbing using e.g https://github.com/micromatch/micromatch?

If it's out of the scope, I'll just create a PR after this is merged.

Since you can't define protos to load at module level, then this would be a handy feature.

@AlexDaSoul
Copy link
Author

AlexDaSoul commented Oct 4, 2019

Could you add support for globbing using e.g https://github.com/micromatch/micromatch?

If it's out of the scope, I'll just create a PR after this is merged.

Since you can't define protos to load at module level, then this would be a handy feature.

It's out of the scope but you can add issue and we discuss this

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 6.9.0 October 31, 2019 12:48
@AlexDaSoul AlexDaSoul force-pushed the feature/grpc-multipackage branch 2 times, most recently from 5ad1559 to 8dffee8 Compare November 16, 2019 18:16
@AlexDaSoul AlexDaSoul closed this Nov 16, 2019
@AlexDaSoul AlexDaSoul mentioned this pull request Nov 16, 2019
3 tasks
@lock
Copy link

lock bot commented Feb 14, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants