-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/grpc multipackage #3418
Feature/grpc multipackage #3418
Conversation
before: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: 'name.package', protoPath: 'alone.proto' } } after: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: ['name.package', 'other.package'], protoPath: [ 'one.proto', 'two.proto', 'any.proto' ] } }
…nfig before: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: 'name.package', protoPath: 'alone.proto' } } after: grpcOptions: <GrpcOptions>{ transport: Transport.GRPC, options: { url: 'url', package: ['name.package', 'other.package'], protoPath: [ 'one.proto', 'two.proto', 'any.proto' ] } }
# Conflicts: # integration/microservices/src/grpc/grpc.controller.ts # packages/microservices/client/client-grpc.ts # packages/microservices/server/server-grpc.ts
Old PR: #3097 |
Pull Request Test Coverage Report for Build 7436
💛 - Coveralls |
@kamilmysliwiec may be use with 'S':
on my current work need this feature ( please answer for question? |
Helpful feature, because usually you need use multiple proto files in each microservice |
Thank you! It will be published as part of a 6.11.0 release. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
before:
after:
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Added use packages and protos from external libraries ang default grpc functionality also https://github.com/grpc/grpc/blob/master/src/proto/grpc/health/v1/health.proto
Does this PR introduce a breaking change?
Other information
Discussion #1733 (comment)