Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature PR: Add request cancellation to http service #3777

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Feature PR: Add request cancellation to http service #3777

merged 1 commit into from
Jan 24, 2020

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Jan 9, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[*] Feature

Does this PR introduce a breaking change?

[ ] Yes
[*] No

Other information

use case:

this.httpService.request(...).pipe(timeout(1000))

we can then cancel this request upon timeout, saving a little bit of resource, and stop axios interceptors processing the timed-out response.

@coveralls
Copy link

coveralls commented Jan 9, 2020

Pull Request Test Coverage Report for Build 11623

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.436%

Totals Coverage Status
Change from base Build 11601: 0.0%
Covered Lines: 4475
Relevant Lines: 4689

💛 - Coveralls

@kamilmysliwiec
Copy link
Member

Very interesting improvement. Thank you!

@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants