refactor(@nestjs/websocket) ws support for connection req

[tannineo]

add a second arg of handleConnection to support (client, req) => {} callback of the connection event

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Current handleConnection of the websocket gateway just apply 1 arg client, which depends on different websocket implements. For socket.io there is only client, but for ws, there're 2 args of the connection event: client, req.

Issue Number: 813

What is the new behavior?

handleConnection now accept 2 args.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[tannineo]

I wonder why npm ci takes so long while npm i on my machine completes successfully...
Need help~

[kamilmysliwiec]

since we don't know the specific list of arguments, maybe we should pass all of them (using rest operator) instead of 2 selected ones

[tannineo]

you are right, I will try to fix.

[coveralls]

Coverage decreased (-0.03%) to 94.623% when pulling e3b9122 on tannineo:813-ws-req-on-connection-fix into 8d62307 on nestjs:master.

[tannineo]

I try to change the code using ... to pass the rest of args and modify a test case.
The coverage falls... I'll try to cover those later...

[kamilmysliwiec]

Any updates here? cc @tannineo

[kamilmysliwiec]

See #813

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.