Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): rename prepublish commands to prepare #878

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

wbhob
Copy link
Contributor

@wbhob wbhob commented Jul 15, 2018

to comply with https://docs.npmjs.com/misc/scripts#deprecation-note

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Other... Please describe: NPM Scripts

What is the current behavior?

Currently warns on install, since npm prepublish was deprecated. This PR introduces the NPM v6-compliant prepare command.

Issue Number: N/A

What is the new behavior?

Instead of running npm prepublish, run npm prepare

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

coveralls commented Jul 15, 2018

Coverage Status

Coverage remained the same at 94.649% when pulling 0bf98c4 on wbhob:npm6-scripts into 8d62307 on nestjs:master.

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 5.2.0 July 25, 2018 17:53
@kamilmysliwiec
Copy link
Member

Thanks 🙂Merged

@kamilmysliwiec kamilmysliwiec merged commit 5f0f6e5 into nestjs:5.2.0 Jul 25, 2018
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants