Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent handle leak in default e2e test #9485

Merged
merged 4 commits into from
Apr 22, 2022
Merged

fix: prevent handle leak in default e2e test #9485

merged 4 commits into from
Apr 22, 2022

Conversation

OSA413
Copy link
Contributor

@OSA413 OSA413 commented Apr 21, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

After the test is run, jest will hang telling

Jest did not exit one second after the test run has completed.

This usually means that there are asynchronous operations that weren't stopped in your tests. Consider running Jest with `--detectOpenHandles` to troubleshoot this issue.

What is the new behavior?

It closes the app so the Jest can exit.

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented Apr 21, 2022

Pull Request Test Coverage Report for Build 9d64d54d-aa97-4252-b895-835046dc5af2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.044%

Totals Coverage Status
Change from base Build 5cf0e473-a21f-4756-8d9d-72a40ee32710: 0.0%
Covered Lines: 5763
Relevant Lines: 6128

💛 - Coveralls

Co-authored-by: Micael Levi L. Cavalcante <mllc@icomp.ufam.edu.br>
@kamilmysliwiec kamilmysliwiec merged commit 1f6fca5 into nestjs:master Apr 22, 2022
@OSA413 OSA413 deleted the patch-1 branch April 22, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants