fix: when generating app with no 'test'/'src' folder to move #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib/sub-app/sub-app.factory.ts
Outdated
| @@ -279,9 +279,8 @@ function moveDirectoryTo( | |||
| tree.getDir(srcDir).visit((filePath: Path, file: Readonly<FileEntry>) => { | |||
| const newFilePath = join(destination as Path, filePath); | |||
| tree.create(newFilePath, file.content); | |||
| tree.delete(filePath); | |||
| tree.delete(srcDir); | |||
There was a problem hiding this comment.
Even though it may fix the reported issue, are we sure that calling tree.delete(srcDir); X times makes sense?
There was a problem hiding this comment.
indeed
although we're calling tree.delete several times, looks like angular schematics is treating such usage:
I'm still trying another way to achieve that. tree.exists didn't worked, just the usual try-catch on tree.delete
Closed
4 tasks
micalevisk
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: closes #1492
given this project:
(note that we have the 'test' folder just to see what's the happy path)
running
npx nest g app quxwill perform the following operations:we are deleting every file within the directories that will be moved ('src' and 'test')
What is the new behavior?
now that same command will do this instead:
when there is no 'test' folder in the project, we'd see:
Does this PR introduce a breaking change?
Other information