Fix circular dependency throws error

[labibramadhan]

Fix circular dependency throws maximum call stack size exceeded

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #136 #175

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[LukvonStrom]

This patch seems valid and solves the recursion issue. Why not merge it @kamilmysliwiec ?

[Hless]

labibramadhan#1

Created pull request on source branch for additional fix. It fixes some typescript compilation errors and also includes fixes for Circular deps between different models (#63), by using a function to resolve the external model, e.g:

// user.entity.ts
// AccessToken will be 'undefined' in runtime,
// because User and AccessToken depend on each other 
@import { AccessToken } from "./acces-token.enitity';
class User {
    ...
    
    @ApiModelProperty({ 
       // Using function instead of object resolves the cyclic depency issues, 
       // since the AccesToken class will be resolved when the decorator runs
        type: type => AccessToken ,  
        isArray: true 
     })
    @OneToMany(type => AccessToken, accessTokens => accessTokens.user)
    accessTokens:AccessToken[]
}

---
// access-token.entity.ts

@import { User } from "./user.entity";
class AccessToken {
    ...
    @ApiModelProperty({
        type: type => User,
     }) 
     @ManyToOne(type => User, user => user.accesTokens)
     user:User
}

[kamilmysliwiec]

Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.