Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@nestjs/swagger) add the ability to work with Nest RouterModule. #54

Closed
wants to merge 50 commits into from
Closed

Conversation

shekohex
Copy link
Contributor

Swagger Package was missing the update about Nest RouterModule package.
this will solve the problem and closes nestjsx/nest-router#3 .

@KhraksMamtsov
Copy link

@shekohex, thank you for that work!
@kamilmysliwiec , thank you for nest! please approve commit))

@kamilmysliwiec
Copy link
Member

Hi @shekohex,
I cannot merge this pull request due to styling changes (perhaps forced by the IDE?) that make this PR huge one and full of needless updates. Could you change only those lines that are critical to integrate nest router?

@shekohex
Copy link
Contributor Author

shekohex commented May 12, 2018

Oh!, yeah of course
I will try with it tonight.

@shekohex
Copy link
Contributor Author

shekohex commented May 13, 2018

phew
Phew, I think it should be get merged now 🎉

@kamilmysliwiec
Copy link
Member

@shekohex there are still +40 files modified with only formatting changes 🙁

@shekohex
Copy link
Contributor Author

@kamilmysliwiec oh !
did you mean that all changes ! i think they are all old PR changes, 6cf9a15 that's the only commit by me.

anyway the VSCode is just using the .prettierrc file and format on save, should i disable it ?

@kamilmysliwiec
Copy link
Member

@shekohex yeah, the formatting changes make almost impossible to review this PR 🙁

@shekohex
Copy link
Contributor Author

Idk, but what about a new PR, should we close this and open a new one, it seems messy here ?

i will open a new PR with only the 3 lines of changes.

@kamilmysliwiec
Copy link
Member

@shekohex would be awesome:)

@shekohex
Copy link
Contributor Author

let's continue here #104

@shekohex shekohex closed this Jun 25, 2018
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nest Router with Swagger doesn't show correct routes
10 participants