Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/extract operator mapping #156

Closed
wants to merge 4 commits into from
Closed

Feature/extract operator mapping #156

wants to merge 4 commits into from

Conversation

Diluka
Copy link
Contributor

@Diluka Diluka commented Jul 12, 2019

@Diluka Diluka requested a review from michaelyali July 12, 2019 09:53
@Diluka
Copy link
Contributor Author

Diluka commented Jul 12, 2019

coverage reduce because the old code has default branch and the operator always match a template.

@Diluka Diluka mentioned this pull request Jul 18, 2019
Merged
@Diluka
Copy link
Contributor Author

Diluka commented Jul 18, 2019 •
edited
Loading

Although this design can be used to implement #149, but it is not able to meet #150.
Considering close this PR.

@michaelyali michaelyali deleted the feature/extract-operator-template branch September 15, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelyali michaelyali Awaiting requested review from michaelyali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[crud-request] CondOperator's value is not match ComparisonOperator's definition
2 participants
@Diluka @michaelyali