Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows an array of filter's and or's in Swagger API #269

Closed
wants to merge 1 commit into from
Closed

fix: allows an array of filter's and or's in Swagger API #269

wants to merge 1 commit into from

Conversation

ignatvilesov
Copy link

Fixes the issue with Swagger metadata that did not allow to use an array of filter and or in TypeScript client.

Actual behavior:
Generated API client did not allow specifying an array of filter and or

CRUD_BEFORE

Expected behavior:
Generated API client allows specifying an array of filter and or

CRUD_AFTER

Generated TS client:

CRUD_generated_dts

Generated JS client:
CRUD_generated_js

@ignatvilesov
Copy link
Author

@zMotivat0r @Diluka Could you please take a look at this PR? It's important for our team as we applied a workaround to apply the same temporary

@michaelyali michaelyali self-requested a review September 23, 2019 17:13
@Diluka
Copy link
Contributor

Diluka commented Sep 24, 2019

duplicate of #198 @zMotivat0r

@Diluka
Copy link
Contributor

Diluka commented Sep 26, 2019

@ignatvilesov You can override the swagger by yourself like this https://gist.github.com/Diluka/8292fced132ff97aa6f04ed5e19a3155

@ignatvilesov
Copy link
Author

@Diluka Thank you for the suggestion. This is how we do in our project but this approach looks a bit hacky 😄
I'd rather prefer to merge #198 to fix it once.

@michaelyali
Copy link
Member

closing this in favor of #198

@michaelyali michaelyali closed this Oct 2, 2019
@ignatvilesov ignatvilesov deleted the fix/swagger-filter branch October 2, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants