Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nested query #35

Closed
wants to merge 9 commits into from
Closed

Feature/nested query #35

wants to merge 9 commits into from

Conversation

Diluka
Copy link
Contributor

@Diluka Diluka commented Mar 5, 2019

filters can be used on relations

@zMotivat0r enhancement of #28

@Diluka
Copy link
Contributor Author

Diluka commented Mar 5, 2019

@zMotivat0r add swagger @ApiOperation title to each route. If missing title the openapi json import to Postman will be empty title. How to test helpers.ts?

@Diluka
Copy link
Contributor Author

Diluka commented Mar 8, 2019

swagger is tested in my project

@michaelyali
Copy link
Member

Hey, @Diluka
Lots of kudos for your effort 🙌
I don't merge it because I'm almost done with the new major version. I'm gonna ask you to rebase once the new version is ready to make sure that everything with this PR looks good, OK?
Cheers!

@Diluka
Copy link
Contributor Author

Diluka commented Mar 21, 2019

@zMotivat0r OK

1. support query on nested fields
2. add more swaggers
fix(core): dynamic create class for inject must change name
fix(swagger): add per_page alias
fix(tslint): suppress warnings and errors
1. page only when page param exists or return list like before
2. page-info response can be custom
3. `take` and `skip` distinguish `0` or `null` to decide if it is paging or listing
4. override `decidePagination` method can make it always paging or listing
@Diluka
Copy link
Contributor Author

Diluka commented Mar 22, 2019

close this open a new for 3.0.0

@Diluka Diluka closed this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants