Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested relations query #28

Merged
merged 4 commits into from
Jan 25, 2019
Merged

nested relations query #28

merged 4 commits into from
Jan 25, 2019

Conversation

Diluka
Copy link
Contributor

@Diluka Diluka commented Jan 22, 2019

new feature to support nested relation query

  1. join can be set with property path like user.projects
  2. parent level join table MUST be set before children like join=users&join=users.projects&join=users.projects.tasks
  3. options shall be placed into each join config although it's the same Entity configured by others due to the options design. Suggest the future version to move @Crud decorator from controllers to entities. And with the concept in auto generate everything from entity #26, the overall configuration will be greatly simplified.

close #23 this feature resolve this issue

1. `join` can be set with property path like `user.projects`
2. parent level `join` table **MUST** be set before children like `join=users&join=users.projects&join=users.projects.tasks`
@michaelyali
Copy link
Member

Hi @Diluka, thanks for your effort. Could you please add changes to the README.md as well? And it would be awesome if you try to play with you changes to make sure that coverage hasn't being decreased. Thanks.

@Diluka
Copy link
Contributor Author

Diluka commented Jan 24, 2019

@zMotivat0r All checks have passed lol

@michaelyali michaelyali merged commit 72dd210 into nestjsx:master Jan 25, 2019
@Diluka Diluka deleted the feature/deep-relations branch January 28, 2019 02:41
@Diluka Diluka mentioned this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to join table?
2 participants