fix(typeorm): filter query wrongly generated #478
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue #401 and issue #321. As described there (#401) if one filters by a certain field. The return field alias is wrong for type ORM.
source #401 (comment)
I was able to reproduce this. I then tried to fix it with these two lines:
https://github.com/joennlae/crud/blob/5687f88de66d7e56bbae228f1d0739de6241ae8a/packages/crud-typeorm/src/typeorm-crud.service.ts#L788-L789
This above two line didn't work when I started to do some sorting queries. Sorting still needs the alias without
"
.Thank you all for this awesome project. I started using it today and I am already a big fan.