Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates dependencies for nestjs v6.0.0. #5

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Updates dependencies for nestjs v6.0.0. #5

merged 2 commits into from
Apr 10, 2019

Conversation

maricn
Copy link
Contributor

@maricn maricn commented Apr 2, 2019 •
edited
Loading

Fixes #4

@bashleigh bashleigh mentioned this pull request Apr 10, 2019
Closed
@bashleigh
Copy link
Contributor

Sorry! Didn't see this PR! I just made #7 which is pretty much the same!

@bashleigh bashleigh self-requested a review April 10, 2019 12:58
@bashleigh bashleigh self-assigned this Apr 10, 2019
@bashleigh bashleigh added the enhancement New feature or request label Apr 10, 2019
bashleigh
bashleigh reviewed Apr 10, 2019
View reviewed changes
src/nest-emitter.module.ts Outdated
@@ -6,6 +6,6 @@ type NestEmitter = NodeJS.Events;
export class NestEmitterModule {
public static forRoot(emitter: NestEmitter): DynamicModule {
const providers: Provider[] = [{ provide: EVENT_EMITTER_TOKEN, useValue: emitter }];
return { module: NestEmitterModule, components: providers, exports: providers };
return { module: NestEmitterModule, providers: providers, exports: providers };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this the shorthand name? I know it's a small opinionated request but would look nicer as {providers,} instead of {providers: providers}

bashleigh
bashleigh approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@bashleigh bashleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment. Not an issue. More of a styling comment but it's not really necessary required to fix.

@bashleigh bashleigh assigned maricn and unassigned bashleigh Apr 10, 2019
@shekohex shekohex requested a review from bashleigh April 10, 2019 16:19
@bashleigh bashleigh merged commit b7b9a70 into nestjsx:master Apr 10, 2019
@maricn maricn deleted the fix-4-update-nestjs-version-6 branch April 11, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashleigh bashleigh Awaiting requested review from bashleigh

Assignees

@maricn maricn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maricn @bashleigh