Fixed issue with exports #22
Conversation
| @@ -15,7 +15,7 @@ | |||
| "rootDir": "./src", | |||
| "baseUrl": "./", | |||
| "outDir": "./dist", | |||
| "lib": ["es2017"] | |||
| "lib": ["es2017", "dom"] | |||
There was a problem hiding this comment.
I thought you would say this! Apparently there's an issue with superagent DefinitelyTyped/DefinitelyTyped#12044 that requires the dom library. I didn't like it but it was the quickest fix but yea. I probably shouldn't have added it. Another method is to create a file declaring the Blob and XmlHttpRequest interfaces and I didn't like that neither
There was a problem hiding this comment.
I don't think the dom library is a good idea tbh
There was a problem hiding this comment.
me too, but anyway we need to investigate more to see what cusses this issue.
is that a typescript issue ?
There was a problem hiding this comment.
I was thinking it might be because I had a different version of node running when I previously built the package?
|
Any news on this PR? |
|
Still not working, any update? |
|
Hey @bashleigh, can I do something to help out on this one? |
|
@jkernech yes please! I'm struggling with my work load and this one is at the back of the queue. There's an issue with building the package for release. Need to remove lib that I added and figure out why the exception is thrown from tsc. Thanks! I'll do my best to come back to this!! |
#21 Imports needed relative path and build required lib dom