Query Builder options

[bashleigh]

Instead of only being limited to repositories, you an pass in a query builder to return the pagination object

#24

[shekohex]

wouldn't it be better to expose the two methods instead of one method for both?

[bashleigh]

Hmmmm I dunno, I like the one method approach. I did export 2 declares though so it's like one method for 2 types? https://github.com/nestjsx/nestjs-typeorm-paginate/pull/28/files#diff-eb13222256edaba485eae8aeb826bc78R10 typeorm does it a lot so wanted to give it a go :p what do you think? @shekohex

[shekohex]

I just don't like the monomorphism and polymorphism in general and i always try to avoid them when possible.

[michaelyali]

SOLID 😉 There are several pros when your methods follow a single responsibility pattern. My favorite one is testing. But, of course, there are situations when you really can't (read don't want to) follow it, but I'm always trying to avoid those.

[johannesschobel]

i would also have used 2 different methods.. but i guess this is a highly opinionated topic :D

[bashleigh]

ok so 2 separate method. I liked the double export though 😂 never mind.

[fwoelffel]

Looks good to me. I have no issue with the polymorphism since the code has been kept trivial and easily testable.

[adrien2p]

I prefer when it respect the single responsibility principle, but that’s my point of view ^^

[nartc]

I do prefer polymorphism since it makes the API more concise.

[shekohex]

Okay i have no problem at all 😊