Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total order #10

Closed
wants to merge 5 commits into from
Closed

Add total order #10

wants to merge 5 commits into from

Conversation

serhii73
Copy link
Collaborator

No description provided.

secondary/app.py Outdated
tr_id = []
lock = Lock()


def extract_data(data: dict):
result = [data[i] for i in sorted(data)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted_data_id can be reused here

secondary/app.py Outdated
@@ -28,15 +40,16 @@ def post():
msg = request.json.get("message")
with lock:
if not id in tr_id:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be replaced with if id not in tr_id

Copy link
Owner

@nestoroprysk nestoroprysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, resolve open comments. Once you're done, ping me, I'll try to investigate tests and cover the new logic with tests (of course, it would be great if you tried to do it on your own).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants