Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query sysbox-fs for it's fuse mountpoint config. #53

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

ctalledo
Copy link
Member

@ctalledo ctalledo commented Jul 7, 2021

This change causes sysbox-runc to query sysbox-fs for the location of the fuse
mountpoint.

Prior to this change, sysbox-runc was assuming the sysbox-fs fuse mountpoint was
located under host directory "/var/lib/sysboxfs", but this may not always be
true given that it's configurable in the sysbox-fs command line.

Fixes Sysbox issue #319.

Signed-off-by: Cesar Talledo ctalledo@nestybox.com

This change causes sysbox-runc to query sysbox-fs for the location of the fuse
mountpoint.

Prior to this change, sysbox-runc was assuming the sysbox-fs fuse mountpoint was
located under host directory "/var/lib/sysboxfs", but this may not always be
true given that it's configurable in the sysbox-fs command line.

Fixes Sysbox issue #319.

Signed-off-by: Cesar Talledo <ctalledo@nestybox.com>
@ctalledo ctalledo requested a review from rodnymolina July 7, 2021 01:06
@ctalledo ctalledo self-assigned this Jul 7, 2021
Copy link
Member

@rodnymolina rodnymolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

libsysbox/syscont/spec.go Show resolved Hide resolved
@ctalledo ctalledo merged commit 9e55c35 into master Jul 7, 2021
@ctalledo ctalledo deleted the sysfs-mountpoint-fix branch July 7, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants