Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysbox-fs --mountpoint flag seems to be ignored #310

Closed
sreya opened this issue Jun 8, 2021 · 2 comments
Closed

sysbox-fs --mountpoint flag seems to be ignored #310

sreya opened this issue Jun 8, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@sreya
Copy link

sreya commented Jun 8, 2021

Repro steps:

# sysbox-mgr --data-root /home/coder/sysbox
# sysbox-fs --mountpoint /home/coder/sysboxfs
# sysbox-runc run test
ERRO[0000] failed to create lib container mount: failed to stat mount source at /var/lib/sysboxfs/test/sys/module/nf_conntrack/parameters/hashsize: stat /var/lib/sysboxfs/test/sys/module/nf_conntrack/parameters/hashsize: no such file or directory
@rodnymolina rodnymolina self-assigned this Jun 8, 2021
@rodnymolina rodnymolina added the bug Something isn't working label Jun 8, 2021
@rodnymolina rodnymolina added this to To do in Sysbox Dev via automation Jun 8, 2021
@rodnymolina rodnymolina added this to the v0.3.1 milestone Jun 8, 2021
@rodnymolina
Copy link
Member

Thanks for reporting this one @sreya.

In regards to the mountpoint knob sysbox-fs seems to be working as expected. Problem appears to be with sysbox-runc which is hard-coding the path on which the rootfs components are mounted (i.e. /var/lib/sysboxfs).

Ideally, sysbox-runc should dynamically extract this information from sysbox-fs during the container initialization. However, the container oci-spec's handling stage (which is the one at which the mountpoints are defined) takes place before sysbox-runc has a chance to interact with sysbox-fs, so at first glance looks like the solution would need to rely on the creation of a new grpc interaction between these two components.

Will think about the best course of action and provide an update asap.

ctalledo added a commit that referenced this issue Jul 7, 2021
The location of the sysbox-fs FUSE dir is configurable
via the sysbox-fs command line. Thus, do not assume
it's under the default location ("/var/lib/sysboxfs")
and instead let sysbox-fs determine its location.

Related to sysbox issue #310.

Signed-off-by: Cesar Talledo <ctalledo@nestybox.com>
ctalledo added a commit that referenced this issue Jul 7, 2021
The location of the sysbox-fs FUSE dir is configurable
via the sysbox-fs command line. Thus, do not assume
it's under the default location ("/var/lib/sysboxfs")
and instead let sysbox-fs determine its location.

Related to sysbox issue #310.

Signed-off-by: Cesar Talledo <ctalledo@nestybox.com>
@ctalledo
Copy link
Member

ctalledo commented Jul 7, 2021

Issue fixed via the following PRs:

nestybox/sysbox-runc#53
nestybox/sysbox-fs#46
nestybox/sysbox-ipc#19

Closing!

@ctalledo ctalledo closed this as completed Jul 7, 2021
Sysbox Dev automation moved this from To do to Done Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Sysbox Dev
  
Done
Development

No branches or pull requests

3 participants